Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement std::error::Error for ParseWeekdayError #745

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Conversation

djc
Copy link
Member

@djc djc commented Jul 27, 2022

Fixes #743. @EvanCarroll any thoughts?

@djc djc requested a review from esheppa July 27, 2022 12:31
@djc djc merged commit 353f179 into main Jul 27, 2022
@djc djc deleted the parse-weekday-error branch July 27, 2022 14:29
@EvanCarroll
Copy link

Looks good to me, I didn't get a chance to confirm if it would work yet but I will today. Thanks for the insanely fast response to time anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: ParseWeekdayError should impl std::fmt::Display and std::error::Error
3 participants